Match vimeo direct urls #1818
Closed
Match vimeo direct urls #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -324,7 +324,7 @@ vjs.Html5.nativeSourceHandler.canHandleSource = function(source){ | |||
| return canPlayType(source.type); | |||
| } else if (source.src) { | |||
| // If no type, fall back to checking 'video/[EXTENSION]' | |||
| match = source.src.match(/\.([^\/\?]+)(\?[^\/]+)?$/i); | |||
| match = source.src.match(/\.([^.\/\?]+)(\?[^\/]+)?$/i); | |||
There was a problem hiding this comment.
I was thinking the period needed to be escaped, but apparently not.
|
looks good! |
|
nice. looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes video.js parse url to detect file type. There was a bug in parsing regexp. Details #1813
Hope
stableis the right branch to merge.contribdoesn't work for me due to this bug contrib/contrib#11